Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend kv.client storeconfig to support memberlist flags #621

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

NickAnge
Copy link
Contributor

@NickAnge NickAnge commented Nov 19, 2024

What this PR does:

  • Expose MemberlistKVConfig as part of the kv.Client's StoreConfig.
  • Register the MemberListKV flags with a specific prefix.

These changes are necessary to enable the -distributor.ha-tracker.memberlist.* flags in Mimir.

Which issue(s) this PR fixes:

Needed for https://github.com/grafana/mimir-squad/issues/2641

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@NickAnge NickAnge force-pushed the nickange/kv/extend-storeconfig-to-support-memberlist branch from 0a9539c to 5a1f174 Compare November 19, 2024 15:59
@NickAnge NickAnge force-pushed the nickange/kv/extend-storeconfig-to-support-memberlist branch from 5a1f174 to 22dbb9e Compare November 19, 2024 16:22
@NickAnge NickAnge marked this pull request as ready for review November 19, 2024 16:51
@NickAnge NickAnge changed the title [draft]feat: extend kv.client storeconfig to support memberlist flags feat: extend kv.client storeconfig to support memberlist flags Nov 19, 2024
Copy link
Contributor

@aldernero aldernero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickAnge NickAnge merged commit f9da728 into main Nov 20, 2024
5 checks passed
@NickAnge NickAnge deleted the nickange/kv/extend-storeconfig-to-support-memberlist branch November 20, 2024 12:46
NickAnge added a commit that referenced this pull request Nov 21, 2024
NickAnge added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants